Navigation block "Open on click": Inherit font style and font weight #40671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When testing, I found that the letter casing is also not working, so I am going to add that. |
|
Size Change: +58 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
carolinan
added
[Block] Navigation
getdave
approved these changes
May 3, 2022
adamziel
added
the
Backport to WP Minor Release
adamziel
pushed a commit
that referenced
this pull request
Jun 21, 2022
…40671) * Inherit font style, font weight and text transform
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 66fb75b |
adamziel
removed
the
Backport to WP Minor Release
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #40669
When the navigation block "Open on click" option is enabled, the menu item link is replaced with a button.
This pr assures that the typography Appearance and Letter case settings work when the option is enabled.
Why?
The font appearance of the menu item should be the same no matter if the "Open on click" option is enabled or not.
How?
Adds
font-style: inherit; font-weight: inherit; text-transform: inherit;when the navigation item is a button (button.wp-block-navigation-item__content).Testing Instructions
Make sure that you have a child page on your WordPress install, to test the page list with child pages.
Screenshots or screencast
Before:
After:
